search

openwrt / packages

Community maintained packages for OpenWrt. Documentation for submitting pull requests is in CONTRIBUTING.md
GNU General Public License v2.0
3.88k stars 3.39k forks source link

unbound: Update to 1.20.0 #24364

Closed Ra2-IFV closed 2 weeks ago

Ra2-IFV commented 2 weeks ago

Maintainer: @1715173329
Compile tested: aarch64 generic 5be9a8790c62a6dca7a4547cd306f54d9bb812d9 Run tested: aarch64 generic 5be9a8790c62a6dca7a4547cd306f54d9bb812d9

Description: I am new to openwrt, please point out my mistakes if I did anything wrong, I'll appreciate it.

1715173329 commented 2 weeks ago

Maintainer is @EricLuehrsen

Legal name is required to sign the commit. See https://openwrt.org/submitting-patches#submission_guidelines.

Ra2-IFV commented 2 weeks ago

Thanks. Reworded commit with real name.

Ra2-IFV commented 2 weeks ago

I'm dumb but I'll learn...

1715173329 commented 2 weeks ago

Please do not close then reopen. If you have your git configured correctly, please update your commit via git commit --amend --reset-author.

Ra2-IFV commented 2 weeks ago

Really sorry for being a trouble maker. I will open a new PR to make everything clean. Apologize again.

1715173329 commented 2 weeks ago

There's nothing to sorry since it's your first-time contribution. Take it easy. You don't need to create a new PR. just update the existing one using git push --force.

Ra2-IFV commented 2 weeks ago

Updated with a detailed commit message with git commit --amend --reset-author.
Thanks again for your patient guidance.

Ra2-IFV commented 2 weeks ago

Hummmm... Seems I'm forced to create a new pull request

1715173329 commented 2 weeks ago

Looks like so.