schroot: add boost-1.85 compatibility patch

[jmarcet]

Maintainer: me Compile tested: master x86_64 Run tested: master x86_64

Description: Fix build failures with boost 1.85, merged on Sunday.

../sbuild/sbuild-run-parts.cc: In constructor 'sbuild::run_parts::run_parts(const std::string&, bool, bool, mode_t)':
../sbuild/sbuild-run-parts.cc:79:22: error: 'directory_iterator' is not a member of 'boost::filesystem'; did you mean 'directory_entry'?
79 |   boost::filesystem::directory_iterator end_iter;
|                      ^~~~~~~~~~~~~~~~~~
|                      directory_entry
../sbuild/sbuild-run-parts.cc:80:27: error: 'directory_iterator' is not a member of 'boost::filesystem'; did you mean 'directory_entry'?
80 |   for (boost::filesystem::directory_iterator dirent(dirpath);
|                           ^~~~~~~~~~~~~~~~~~
|                           directory_entry
../sbuild/sbuild-run-parts.cc:81:8: error: 'dirent' was not declared in this scope
81 |        dirent != end_iter;
|        ^~~~~~
../sbuild/sbuild-run-parts.cc:81:18: error: 'end_iter' was not declared in this scope
81 |        dirent != end_iter;
|                  ^~~~~~~~
ninja: build stopped: subcommand failed.

../sbuild/sbuild-chroot-config.cc: In member function 'void sbuild::chroot_config::add_config_directory(const std::string&, const std::string&)':
../sbuild/sbuild-chroot-config.cc:152:22: error: 'directory_iterator' is not a member of 'boost::filesystem'; did you mean 'directory_entry'?
152 |   boost::filesystem::directory_iterator end_iter;
|                      ^~~~~~~~~~~~~~~~~~
|                      directory_entry
../sbuild/sbuild-chroot-config.cc:153:27: error: 'directory_iterator' is not a member of 'boost::filesystem'; did you mean 'directory_entry'?
153 |   for (boost::filesystem::directory_iterator dirent(dirpath);
|                           ^~~~~~~~~~~~~~~~~~
|                           directory_entry
../sbuild/sbuild-chroot-config.cc:154:8: error: 'dirent' was not declared in this scope
154 |        dirent != end_iter;
|        ^~~~~~
../sbuild/sbuild-chroot-config.cc:154:18: error: 'end_iter' was not declared in this scope
154 |        dirent != end_iter;
|                  ^~~~~~~~
ninja: build stopped: subcommand failed.

./build_dir/target-x86_64_musl/reschroot-1.6.13/reschroot/sbuild/sbuild-util.cc:38:10: fatal error: boost/filesystem/convenience.hpp: No such file or directory
38 | #include <boost/filesystem/convenience.hpp>
|          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
ninja: build stopped: subcommand failed.

[BKPepe]

Is the patch part of upstream repository? If not, would you mind sending it there, please? It would really help us as many contributors and maintainers are trying to have as many patches as packages in this repository, and it leads to a maintenance burden. Kindly appreciated 🙌

[jmarcet]

Is the patch part of upstream repository? If not, would you mind sending it there, please? It would really help us as many contributors and maintainers are trying to have as many patches as packages in this repository, and it leads to a maintenance burden. Kindly appreciated 🙌

@BKPepe

Sadly upstream looks kind of abandoned. Last commit is from 2 years ago, with PRs unanswered for over a year.

[BKPepe]

If upstream does not care, should we? It looks like we should remove this package as upstream is dead. 🤷‍♂️

[jmarcet]

Not sure about that. Both Arch and Debian still carry it. They have not changed upstream either so far.

[neheb]

PKG_RELEASE bump

[BKPepe]

Not sure about that. Both Arch and Debian still carry it. They have not changed upstream either so far.

However, there do have more man power than we do. More tests, more of everything, I would say. Debian and as well Arch Linux are even deployed on so many devices. Right now, if there is some security incident, some issue, why it does not work, we need to step in and do that because no one in upstream does that.

Sometimes, it is good to move on the things, which are activately maintained.

PKG_RELEASE bump

Not only that, patch can not be applied with Git am, this means that Git author, subject, description, etc. is missing.