search

openwrt / packages

Community maintained packages for OpenWrt. Documentation for submitting pull requests is in CONTRIBUTING.md
GNU General Public License v2.0
3.94k stars 3.46k forks source link

dnsproxy - latest update requires changes to init.d/dnsproxy #24869

Closed cyformatician closed 4 weeks ago

cyformatician commented 1 month ago

Maintainer: @1715173329 Environment: platform independent

Description:

Latest dnsproxy update .73.0 with a fix released in .73.1 introduces a new option --hosts-file-enabled which must be added/declared in init.d as adding it to the config file is insufficient. Also, the global option hosts_file_enabled with value 'false' must be set in config/dnsproxy as the option is enabled by default which breaks dnsproxy.

Do note that if this new option is enabled without a valid hosts file assigned with --hosts-files, dnsproxy crashes/errors out.

append_param_arg "global" "hosts_file_enabled" "--hosts-file-enabled"
1715173329 commented 4 weeks ago

Ping @p-w-p could you check it please?

1715173329 commented 4 weeks ago

please check if #24875 fixes your issue

p-w-p commented 4 weeks ago

Ping @p-w-p could you check it please?

Sorry, I didn't try an invalid hosts file when running the tests. Thanks for the patch!

cyformatician commented 4 weeks ago

Confirmed - fix works as expected.

Thanks everyone!