search

openwrt / packages

Community maintained packages for OpenWrt. Documentation for submitting pull requests is in CONTRIBUTING.md
GNU General Public License v2.0
3.94k stars 3.45k forks source link

i2pd package improvements #8088

Closed dartraiden closed 5 years ago

dartraiden commented 5 years ago

@yangfl

1) subscriptions.txt is not used by i2pd daemon and deprecated so we can remove it from Makefile

https://github.com/openwrt/packages/blob/a50f269411ba6538665ff840e44f5d9eab8b9834/net/i2pd/Makefile#L42 https://github.com/openwrt/packages/blob/a50f269411ba6538665ff840e44f5d9eab8b9834/net/i2pd/Makefile#L60

2) It's better to use INSTALL_CONF instead of INSTALL_BIN for configs

https://github.com/openwrt/packages/blob/a50f269411ba6538665ff840e44f5d9eab8b9834/net/i2pd/Makefile#L55 https://github.com/openwrt/packages/blob/a50f269411ba6538665ff840e44f5d9eab8b9834/net/i2pd/Makefile#L61

neheb commented 5 years ago

This is fixed.