search

openwrt / packages

Community maintained packages for OpenWrt. Documentation for submitting pull requests is in CONTRIBUTING.md
GNU General Public License v2.0
3.95k stars 3.46k forks source link

yggdrasil: why is MIPS FPU emulator a dependency? #8457

Closed dengqf6 closed 5 years ago

dengqf6 commented 5 years ago

@wfleurant @aparcar If I recall right, current version of Golang compiler already supports softfp. Besides that, there is mips24kf, which has an FPU.

wfleurant commented 5 years ago

The latest Golang compiler did not produce a usable mips32r2 binary for kernels lacking FPU emulation support.

If the case is 'mips' being too broad then we'll have to possibly exclude based on subtargets (if possible).

DEPENDS:=$(GO_ARCH_DEPENDS) @IPV6 +kmod-tun +@(mips):KERNEL_MIPS_FPU_EMULATOR

Are you able to test on mips24K devices? I'll continue to look further into this...

Is it possible these lantiq subtargets have hardware FPU? xrx200 xway xway_legacy falcon ase

jow- commented 5 years ago

+@(mips):KERNEL_MIPS_FPU_EMULATOR

Please do not enable kernel features from packages! Doing so will bloat the kernel image for all targets when the package happens to be built along with the base system by the buildbots.

wfleurant commented 5 years ago

right, there is better method im looking at lang/node/Makefile, DEPENDS:=@(HAS_FPU||KERNEL_MIPS_FPU_EMULATOR)

dengqf6 commented 5 years ago

There are already some Golang packages, which don't depend on FPU emulator in this repo, such as geth. @jefferyto