search

openwrt / routing

OpenWrt Routing Packages
328 stars 369 forks source link

mcproxy: fix igmpv3 and mld record type #1032

Open rthakur33 opened 10 months ago

rthakur33 commented 10 months ago

This patch fixes that if IGMPv3 Membership Report packet on the LAN interface with ALLOW_NEW_SOURCES record containing specific source is sent, then IGMPv3 Membership Report packet is received on the WAN interface and group record is ALLOW_NEW_SOURCES for the group with a matching source list.

mwarning commented 10 months ago

@sbyx ping

BKPepe commented 7 months ago

Is this patch included in upstream? If not, are you willing to send it there?

rthakur33 commented 7 months ago

Is this patch included in upstream? If not, are you willing to send it there?

@BKPepe , thanks for your comment, I actually tried there first https://github.com/mcproxy/mcproxy/pull/18 but got no response hence raised this as a patch here.

BKPepe commented 1 month ago

I was thinking, if the upstream is dead for more than 7 years. What about rather dropping this package at all? Here are a few points which leads that removing is gonna be helpful:

Sometimes, it is just better to move on instead of relying on something which is obviously not working.

rthakur33 commented 1 month ago

I was thinking, if the upstream is dead for more than 7 years. What about rather dropping this package at all? Here are a few points which leads that removing is gonna be helpful:

  • If there is any issue (bug/security vulnerability), upstream developers probably will not look into it.
  • If you want to have fixed something there, then most likely, it will not get any attention as well.
  • I am not able to see this package in other GNU/Linux distributions such as Debian, Ubuntu, etc.

Sometimes, it is just better to move on instead of relying on something which is obviously not working.

+1 from me.

BKPepe commented 1 month ago

I will create PR for removal shortly.