search

openwrt / routing

OpenWrt Routing Packages
328 stars 369 forks source link

opennds: update to version 10.2.0 #1034

Closed bluewavenet closed 9 months ago

bluewavenet commented 9 months ago

Maintainer: Rob White rob@blue-wave.net

Compile tested: arm_cortex-a7_neon-vfpv4, mipsel_24kc, x86-64

Run tested: arm_cortex-a7_neon-vfpv4, mipsel_24kc, x86-64; on snapshot, 23.05, 22.03

Description: opennds (10.2.0) - This version is a minor upgrade that introduces some significant additional functionality. In addition it includes numerous enhancements bug fixes and cosmetic fixes.

Additional functionality includes:

Details can be found here: https://github.com/openNDS/openNDS/releases/tag/v10.2.0

Signed-off-by: Rob White rob@blue-wave.net

bluewavenet commented 9 months ago

@mwarning @PolynomialDivision @BKPepe All tests passed. Good to go....

BKPepe commented 9 months ago

I do have one remark here. We don't need to copy&paste things from your tagged release in the commit description. Just point there your tag, where users which are interested in it can find it.

Overally, my idea is that in the commit description should be only relevant changes to package or files, which are here (init script, config file, etc.) and not describing all those changes which was done in the source code. It makes everything huge, which could lead to misunderstanding.

So... commit description:

bluewavenet commented 9 months ago

@BKPepe I have done it this way for some considerable time, born of frustration of finding commit/pr comments that convey almost zero information, making it very hard work to follow what is actually going on.

It is very refreshing to get feedback on this and yes I wholeheartedly agree with your idea as it will convey the same information as my method but in a much more condensed and readable form - for the same minimal effort that my verbose cut&paste involves.

I have edited accordingly. How does it look now?

BKPepe commented 9 months ago

Yeah, its better! You got the idea in the PR, which you edited. Good work.

Next time, we can keep working on it to improve it even more. :)

Please do the same thing in your commit and force push it, then I will merge it.

bluewavenet commented 9 months ago

@BKPepe

Next time, we can keep working on it to improve it even more

Indeed. A user guide or similar would be useful. Do you know if there is one? I can't find anything, particularly with regards to the many options for the makefile....

bluewavenet commented 9 months ago

@BKPepe

Please do the same thing in your commit and force push it, then I will merge it.

Done.

bluewavenet commented 9 months ago

@BKPepe

Ready to go...

BKPepe commented 9 months ago

A user guide or similar would be useful. Do you know if there is one? I can't find anything, particularly with regards to the many options for the makefile....

Hmm, I dont think so. :) Best practices applies here.

bluewavenet commented 9 months ago

@BKPepe Thank you!

Best practices applies here.

Lol - So is there a list of best practices? ;-D

BKPepe commented 9 months ago

Haha, good joke. Nope. =D