search

openwrt / routing

OpenWrt Routing Packages
323 stars 362 forks source link

nodogsplash: missing configuration values in uci #80

Closed lynxis closed 9 years ago

lynxis commented 9 years ago

Hi @mwarning

uci is sadly still missing some configuration values. Can you take a look on these?

make sense

  { "debuglevel", oDebugLevel },
  { "splashpage", oSplashPage },
  { "webroot", oWebRoot },
  { "pagesdir", oPagesDir },
  { "checkinterval", oCheckInterval },
  { "syslogfacility", oSyslogFacility },
  { "gatewayiprange", oGatewayIPRange },

don't makes sense

  { "daemon", oDaemon }, /* procd takes care */
  { "setmss", oSetMSS }, /* firewall takes care of this */
  { "mssvalue", oMSSValue }, /* this tooo */
  { "downloadimq", oDownloadIMQ }, /* Is IMQ still support by OpenWrts Linux Kernel? As far I know this is broken on OpenWrt  */
  { "uploadimq", oUploadIMQ },   /* this too' */
  { "ndsctlsocket", oNdsctlSocket }, /* dont think we need to change it */

may be useful, but I don't know what these do?!

  { "remoteauthenticatoraction", oRemoteAuthenticatorAction },
  { "enablepreauth", oEnablePreAuth },
  { "binvoucher", oBinVoucher },
  { "forcevoucher", oForceVoucher },
  { "passwordauthentication", oPasswordAuthentication },
  { "usernameauthentication", oUsernameAuthentication },
  { "passwordattempts", oPasswordAttempts },
  { "username", oUsername },
  { "password", oPassword },
  { "authenticateimmediately",  oAuthenticateImmediately },

  { "decongesthttpdthreads", oDecongestHttpdThreads },
  { "httpdthreadthreshold", oHttpdThreadThreshold },
  { "httpdthreaddelayms", oHttpdThreadDelayMS },

  { "FW_MARK_AUTHENTICATED", oFWMarkAuthenticated },
  { "FW_MARK_TRUSTED", oFWMarkTrusted },
  { "FW_MARK_BLOCKED", oFWMarkBlocked },

already implemented

  { "maxclients", oMaxClients },
  { "gatewayname", oGatewayName },
  { "gatewayaddress", oGatewayAddress },
  { "gatewayport", oGatewayPort },
  { "redirectURL", oRedirectURL },
  { "imagesdir", oImagesDir },
  { "clientidletimeout", oClientIdleTimeout },
  { "clientforcetimeout", oClientForceTimeout },
  { "trafficcontrol", oTrafficControl },
  { "downloadlimit", oDownloadLimit },
  { "uploadlimit", oUploadLimit },
  { "trustedmaclist", oTrustedMACList },
  { "blockedmaclist", oBlockedMACList },
  { "allowedmaclist", oAllowedMACList },
  { "MACmechanism", oMACmechanism },
  { "firewallruleset", oFirewallRuleSet },
  { "firewallrule", oFirewallRule },
  { "emptyrulesetpolicy", oEmptyRuleSetPolicy },
  { "gatewayinterface", oGatewayInterface },
mwarning commented 9 years ago

The options of the first sections also do make sense to me. :)

About the second section, "downloadimq" and "uploadimq" migh be broken, but it is probably not hard to fix it. I haven't had any time though. So it does not hurt to support them for OpenWrt. I agree with the rest, we do not need them.

They options of the third section are all useful and we would do good to allow them. :)

EDIT: rewording