openwrt / routing

OpenWrt Routing Packages
334 stars 378 forks source link

bird1-openwrt: use a single Makefile for IPv4 and IPv6 packages #928

Closed rogerpueyo closed 1 year ago

rogerpueyo commented 1 year ago

Having two Makefile files, respectively in the bird1-openwrt-ipv4 and bird1-ipv6-openwrt folders, made the commit tests fail due to a compilation error at the time of building the packages. This patch merges both files into a single Makefile. As a result, package compilation succeeds and all commit tests can be passed.

Signed-off-by: Roger Pueyo Centelles roger.pueyo@guifi.net

mwarning commented 1 year ago

There seems to be some problem with the ucode package on powerpc_8540

rogerpueyo commented 1 year ago

There seems to be some problem with the ucode package on powerpc_8540

I doubt this is related to the bird1-openwrt packages. All other architectures passed successfully, and powerpc_8540 used to pass too, a few weeks ago.

Indeed, this unrelated commit from yesterday also made the powerpc_8540 test fail.

Please, also see that an empty commit makes the powerpc_8540 test fail too.

rogerpueyo commented 1 year ago

Hi, @mwarning,

There seems to be some problem with the ucode package on powerpc_8540

I believe the problem is caused by the ucode package itself, and only affects the powerpc_8540 architecture. Indeed, even an empty commit triggers the same error, and only on that same architecture.

I'd kindly ask you --or any other person with permissions to do it-- to consider merging the commit, even if the powerpc_8540 test fails, as the error is unrelated to the bird1-openwrt package. This way, I'll be able to update PRs #921 and #923 accordingly.

For your convenience, I just rebased with upstream/master.

Thanks!

mwarning commented 1 year ago

hi, let's wait for the current pipeline to run. Let's merge after that.