search

openwrt / routing

OpenWrt Routing Packages
330 stars 370 forks source link

cjdns: pass for dangling pointer warning #961

Closed VenetiaFurtado closed 1 year ago

VenetiaFurtado commented 1 year ago

Maintainer: @wfleurant Compile tested: builds for x86_64 Run tested: Build only testing

Description: same build error seen on my machine as seen in https://github.com/openwrt/routing/issues/958 Fix proposed is similar to https://github.com/openwrt/routing/issues/738

BKPepe commented 1 year ago

We can proceed further, but the formality check fails for you. Would you mind to fix it, please?

VenetiaFurtado commented 1 year ago

We can proceed further, but the formality check fails for you. Would you mind to fix it, please?

Thank you for your reply. I have fixed the commit message as per the submission guideline.

wfleurant commented 1 year ago

no objections

wfleurant commented 1 year ago

@cjdelisle please advise if you're not too busy

cjdelisle commented 1 year ago

Oh, that's a bug in cjdns. What version are you using? I can push a fix against that version.

VenetiaFurtado commented 1 year ago

It looks like version v21.1 is being used. https://github.com/openwrt/routing/blob/master/cjdns/Makefile#L20

cjdelisle commented 1 year ago

I fixed the cause of the issue here: https://github.com/openwrt/routing/pull/964 Thanks for bringing this to my attention.