openwrt / telephony

The telephony packages feed
105 stars 246 forks source link

asterisk: don't send stdout to syslog by default #739

Closed pprindeville closed 2 years ago

pprindeville commented 2 years ago

Maintainer: @jslachta Compile tested: x86_64, generic, HEAD (236c3ea730) Run tested: same, installed & running on production PBX

Description:

Don't duplicate console tracing into /var/log/messages.

micmac1 commented 2 years ago

I'd argue the default setting to log to syslog helps new users. You see what's going on in the syslog. And once they're comfy they can turn it off.

micmac1 commented 2 years ago

And the commit subject is misleading. You're just changing the default.

pprindeville commented 2 years ago

I'd argue the default setting to log to syslog helps new users. You see what's going on in the syslog. And once they're comfy they can turn it off.

I don't think making new users' lives easier justifies potentially filling up the filesystem.

micmac1 commented 2 years ago

I don't think making new users' lives easier justifies potentially filling up the filesystem.

If writing to /var/log/messages fills up a user's file system I'd suggest to configure proper log rotation.

pprindeville commented 2 years ago

I don't think making new users' lives easier justifies potentially filling up the filesystem. If writing to /var/log/messages fills up a user's file system I'd suggest to configure proper log rotation.

And that is supposedly easier for new users to do?

micmac1 commented 2 years ago

I don't think making new users' lives easier justifies potentially filling up the filesystem. If writing to /var/log/messages fills up a user's file system I'd suggest to configure proper log rotation.

And that is supposedly easier for new users to do?

Normally users don't have to bother with this. Their distro does it for them. In OpenWrt /var/log/messages is not used by default. I'm guessing you installed some extra syslog daemon.

pprindeville commented 2 years ago

Normally users don't have to bother with this. Their distro does it for them. In OpenWrt /var/log/messages is not used by default. I'm guessing you installed some extra syslog daemon.

All that's needed is to change /etc/config/system to:

config system
        ...
        option log_file '/var/log/messages'
        option log_type 'file'

That will work with the stock BusyBox syslogd.

micmac1 commented 2 years ago

All that's needed is to change /etc/config/system to:

config system
       ...
       option log_file '/var/log/messages'
       option log_type 'file'

That will work with the stock BusyBox syslogd.

Anyway, the user has got to roll the file, anything can log to it. It's unrelated to asterisk.

pprindeville commented 2 years ago

@jslachta Care to weigh in?

jslachta commented 2 years ago

@pprindeville, ACK.

pprindeville commented 2 years ago

Thanks!