openwrt / telephony

The telephony packages feed
103 stars 232 forks source link

siproxd: improve network device resolution #843

Closed guidosarducci closed 7 months ago

guidosarducci commented 7 months ago

Maintainer: @micmac1 @jslachta

Description: Resolve network devices by first trying network_get_device (L3) and falling back to network_get_physdev (L2) on failure, which allows using Wireguard interfaces. Both are needed to avoid breaking existing usage for some interfaces (e.g. wan).

Also add myself as a maintainer.

This might help or fix #800, but I can't reproduce the error myself and don't have a VOIP-over-Wireguard setup at hand.

Testing: Compile tested for ipq40xx, targeting EA6350v3 device on master.

Run tested on EA6350v3 with 23.05.2. Checked problems with network_get_device and network_get_physdev from CLI, and confirmed siproxd config file /var/etc/siproxd/siproxd-general.conf contains correct wg interface after startup with this change.

jslachta commented 7 months ago

Hi Tony (@guidosarducci),

I accept your changes. Thank you!

Kind regards, Jiri