openwrt / telephony

The telephony packages feed
104 stars 256 forks source link

baresip,libre: Update to version 3.16.0 #885

Closed dddaniel closed 2 weeks ago

dddaniel commented 2 weeks ago

The previous version 1.1.0 is about 7 years old now and a lot has changed. Various fixes, improvements and features have been added.

The build system has moved to cmake and pkg-config is used, which makes it a lot easier to build from the openwrt buildroot. Therefore a lot of the extra code is removed from the makefiles.

librem is now integrated into libre.

No more patches are required.

jslachta commented 2 weeks ago

Hello Daniel (@dddaniel),

given our limited maintainer capacity, could you at least provide information on the run-tests and confirm whether Baresip can still run after your changes? Just a formal check.

Kind regards, Jiri

dddaniel commented 2 weeks ago

Hi @jslachta, I ran a couple of x86 builds with all plugins enabled. Besides that I am actively using it.

There will be a couple follow up PR's regarding the init script that isn't running in it's current form. (Also in the previous version, because of a missing user) In addition I would like to add UCI support for it. The current /etc/default/baresip doesn't integrate well into openwrt.

jslachta commented 2 weeks ago

Thank you, Daniel (@dddaniel ). Your PR looks ready to merge. It looks like the test builds are currently broken. I'll check them first and then rerun. If the build succeeds, I’ll proceed with merging your PR.

Ansuel commented 2 weeks ago

@dddaniel can you rebase this on top of master?

jslachta commented 2 weeks ago

Thank you, Christian (@Ansuel), for updating the GitHub workflow.

dddaniel commented 2 weeks ago

Hi @jslachta, I just found out during testing that some of the old plugins have been moved to a new repo called baresip-apps. In order to have all the features available with this update, there needs to be a new package added. So I will close this PR for now and create a new one when it's done.