search

openwsn-berkeley / dissectors

6TiSCH/IEEE802.15.4e Wireshark dissectors
Other
8 stars 7 forks source link

Fixing HIE time correction parsing-error that caused malformed pckts #8

Closed mstaflex closed 9 years ago

mstaflex commented 9 years ago

This error lead to situations were non-HIE-termination IE were not parsed, which then lead to malformed frames.

HIE-TERM-IE were correctly dissected if they were the only HIEs. However, when there was e.g. a time correction HIE first (currently the only supported HIE), it was checked in the default branch of the switch statement, if the dissecting should stop (because the end of the HIE area was reached), which is apparently wrong for the time correction HIE.

This was easily fixable by introducing the else.

Signed-off-by: mstaflex jasper.buesch@gmail.com

jmmunoz86 commented 9 years ago

Hi, could you send me the pcap file you got in order to test this?

I'd like to improve this dissector but I don't have a variety of pcap files.

Thanks!