Privatize EADItem details, increase label range to i16 - Githubissues

openwsn-berkeley / lakers

EDHOC implemented in Rust, optimized for microcontrollers, with bindings for C and Python.

https://crates.io/crates/lakers

BSD 3-Clause "New" or "Revised" License

13 stars 10 forks source link

Privatize EADItem details, increase label range to i16 #100

Open chrysn opened 1 year ago

chrysn commented 1 year ago

While it has practical uses (I'd like to utilize the library with https://datatracker.ietf.org/doc/draft-amsuess-core-edhoc-grease/, although that'll need the u16 or practically i32 points), its main purpose is to check whether my understanding of the code is good enough to pass CI.

I'd still ask for reviews towards merging because

having fewer pub items makes for a better evolvable library, and
I expect that EAD extensions that are somewhat larger will stay clear of the u8 range to leave it for every-byte-counts applications.

geonnave commented 1 year ago

Thanks for this PR @chrysn. Left a few comments in the code. I assume you were waiting for a feedback before adjusting other impacted areas of the library.