openwsn-berkeley / lakers

EDHOC implemented in Rust, optimized for microcontrollers, with bindings for C and Python.
https://crates.io/crates/lakers
BSD 3-Clause "New" or "Revised" License
13 stars 10 forks source link

Allow applications to pick their C_x #104

Closed chrysn closed 1 year ago

chrysn commented 1 year ago

Applications may need to pick their own C_x (as opposed to the EDHOC library picking one at random, as it was before) for three reasons:

This will likely need follow-ups for similarly delegating the choice of {ID_,}CRED_peer to the callers (resolving #99 issues from), but those are separate enough that I'd do them in a separate PR.

These are API breaking changes. They're split in two because I did C_R first, and kept them split to ease review especially on the CI side; when ACK'ed, I'd like to squash them.

geonnave commented 1 year ago

Thanks @chrysn, it looks good. Left a minor comment. As for merging, maybe we could merge it directly into the remove-hacspec branch I just pushed upstream.

chrysn commented 1 year ago

This is now only one commit atop #106. Rebasing was a bit of a hassle, but worked in a mixed cherry-pick and manual application approach. Looks like remove-hacspec is in a stable enough shape to rebase onto, at any rate, and things are much easier on that!

From my PoV, this is done once CI says Go.

geonnave commented 1 year ago

Great! Merged into remove-hacspec.