Closed chrysn closed 7 months ago
CI passes, marking this ready-for-review.
Versions are still as 0.4.0-alpha.1, which I think makes sense for a first upload.
With that, first uploads should be possible any time (especially given the alpha version number). The first upload is probably where we'll find that some properties of the crates are not yet matching crates.io's expectations -- can I just go ahead and upload, so that we can then figure out a more long-term release ... aehm, layup process?
This looks good to me. lakers-shared
is indeed more aligned with its current functionality, and ead-dispatch
too. I think I am missing the reason for not renaming edhoc-crypto
to lakers-crypto-dispatch
.
I think I am missing the reason for not renaming
edhoc-crypto
tolakers-crypto-dispatch
.
edhoc-crypto, and the other non-renamed crates, are just not part of the initial upload. When renaming everything, I wouldn't be sure where to stop (like, examples too?), so I've picked a minimal set necessary for the task at hand.
Sounds good!
Picking "lakers" as discussed in today's call with @malishav and @geonnave. This PR only renames the crates that'd actually go to crates.io, and uses
All the renaming is for now purely local to the Cargo.toml files; inside Rust no identifiers are replaced. We'll probably want to do that at some point in time, but that's best done on a flag day when nobody has any pending PRs or (worse) local changes, as that's a big search-and-replace (and may make sense together with directory renaming etc).
I'll probably need one or two iterations on CI to fix mentions of names I haven't found in local testing.