My initial goal was to get rid of IdCredOwned, and replace it with CredentialRPK, but then fields such as CredentialRPK.value would have to be Optional, spreading around runtime checks that would otherwise not be needed.
So I've decided to just keep IdCredOwned as is.
Thus, the main change in this PR is the addition of the CredentialRPK type which owns its contents and provide static access to fields such as public_key and id_cred, thus removing one potential source of panics from the protocol core.
My initial goal was to get rid of
IdCredOwned, and replace it withCredentialRPK, but then fields such asCredentialRPK.valuewould have to beOptional, spreading around runtime checks that would otherwise not be needed.So I've decided to just keep
IdCredOwnedas is.Thus, the main change in this PR is the addition of the
CredentialRPKtype which owns its contents and provide static access to fields such aspublic_keyandid_cred, thus removing one potential source of panics from the protocol core.