Closed geonnave closed 1 year ago
Yes, it is because of the different types.
Before invoking the hacspec function, why don't you convert the array to ByteSeq
like in https://github.com/openwsn-berkeley/edhoc-rs/blob/main/crypto/edhoc-crypto-hacspec/src/lib.rs#L50? This would avoid code duplication from hacspec
You are right, fixed.
Since this is now implemented, could you remove the G_X, X, G_Y, Y
constants from consts/src/lib.rs
for both modules?
Since this is now implemented, could you remove the G_X, X, G_Y, Y constants from consts/src/lib.rs for both modules?
I can remove Y
and G_Y
, as I am still using X
and G_X
for tests.
But why don't you move X
and G_X
then as test vectors in the test module? They should definitely not appear any more in consts
.
But why don't you move
X
andG_X
then as test vectors in the test module? They should definitely not appear any more inconsts
.
Sounds good, will do it.
Congrats on getting this ready for merge! Merging now!
Addressing #41 and #42.
This PR adds support for generation of ephemeral private keys, as well as derivation of public keys. It also updates
prepare_message_1
andprepare_message_2
to accept an ephemeral keypair as parameter.The implementation differs for each crypto backend: