search

openx / OX3-Python-API-Client

Helper class for accessing the OX3 API - Requires https://github.com/simplegeo/python-oauth2
Other
8 stars 17 forks source link

Added python 3 support and cleaned up some testing files #22

Closed henryrizzi closed 7 years ago

henryrizzi commented 8 years ago

I changed the library to use response.text rather than response.content as this will allow the text to be automatically decoded in both python 2.6+ and python 3. Also, the six library is used to bridge the gap between python 2 and 3.

henryrizzi commented 8 years ago

The trailing whitespace has been purged from init.py client.py has been fixed to not use any fancy 2.7 features context features

The client.py tests won't all run right now, but the delete test is still failing on master. On python 2.6, a few tests will fail because of differences in the way that failUnlessRaises works in different versions, but the actual api should still function.

henryrizzi commented 8 years ago

I just removed those folders from my .gitignore. the egg-info is jut the file generated in python3 when you run python setup.py develop and the other ones are for installing using python2 variants. landing was just specific to me, but I removed all 4 items from the .gitignore anyway.

marcsantiago commented 8 years ago

How stable is this branch for production? It looks a lot cleaner than the requests_oauthlib branch i'm currently using.

henryrizzi commented 8 years ago

I've used it to get a lot of reports, but so far haven't had to do anything with deleting, posting or putting. For getting reports at least, it is very stable and I haven't run into any issues so far on python 3.5.2

haohany commented 8 years ago

I use it mainly to create and delete objects in API. requests_oauthlib is merged into this branch and some bugs are fixed.

henryrizzi commented 8 years ago

Has anyone else tested this for their use case using python 3?

openx-luis commented 7 years ago

Superseded by https://github.com/openx/OX3-Python-API-Client/pull/33