search

openx / OX3-Python-API-Client

Helper class for accessing the OX3 API - Requires https://github.com/simplegeo/python-oauth2
Other
8 stars 17 forks source link

Fixing `upload_creative` method #31

Closed arseniy-panfilov closed 4 years ago

arseniy-panfilov commented 7 years ago

Hi folks and thanks for this amazing library! I've found it very useful but encountered some issues which I had to fix in order to be able to make use of some openx functionality.

In this PR I address upload_creative method which sadly didn't work for me at all. Please take a look on line comments where I describe every obstacle I've stumbled upon.

emilyzzz commented 7 years ago

Thank you @arseniy-panfilov for filing this issue with us. We'll take a look at this. If you can provide how urgent this is, this can help us prioritize. Thanks

arseniy-panfilov commented 7 years ago

@emilyzzz it's not very urgent: I'm using "inherit & override" so far to introduce all the necessary changes to the client class and I'm happy enough with it. But of course it would be nice to be able to use the client as-is and get rid of extra code eventually :+1:

ikari-pl commented 4 years ago

I liked how this PR was nice and well commented... however we don't upload creatives into the API anymore (ad-server went away May 2019)... I'd have to understand the now-to-be-removed code better to even solve the conflict... I'll close it, with some sadness.