search

openx / OX3-Python-API-Client

Helper class for accessing the OX3 API - Requires https://github.com/simplegeo/python-oauth2
Other
8 stars 17 forks source link

Update the Python 3 PR #33

Closed flaker closed 7 years ago

flaker commented 7 years ago
flaker commented 7 years ago

I could not override the mock for test_delete. All the tests are sharing the same mocks, client, etc which makes things a bit more difficult. Refactoring them allowing each test to change the mocks with no side effects would be nice. Also I removed some tests that were not real tests (just a 'pass')

This PR was tested under Python 2.7.13 and 3.6.1 with the following list of pkgs:

$ pip freeze
certifi==2017.4.17
chardet==3.0.4
idna==2.5
mock==2.0.0
oauthlib==2.0.2
pbr==3.0.1
requests==2.18.1
requests-oauthlib==0.8.0
six==1.10.0
urllib3==1.21.1
flaker commented 7 years ago

Removed the shared state between tests.

openx-luis commented 7 years ago

Looks good now.