search

openx / OX3-Python-API-Client

Helper class for accessing the OX3 API - Requires https://github.com/simplegeo/python-oauth2
Other
8 stars 17 forks source link

Sg fix library #44

Closed siddharthgurdasani-openX closed 4 years ago

laurb9 commented 5 years ago

Please reference a ticket describing the problem, or a description, so we can tell what is being addressed ?

I see signature changes to methods that make optional arguments required - they may break existing code that other clients might be using. There are some debugging statements like print left in the code. There are also duplicated code into specialized methods that don't appear to add functionality other than debugging.

ikari-pl commented 5 years ago

Adding lines that are commented out doesn't look clean either (let's remember it's public code). I wonder if the url[1] + url[2] + url[3] parts could be made more readable (with a named tuple or an URL class?), though that is not a new change.