search

openx / ox-bqpipeline

python framework for authoring BigQuery Pipelines for scheduling
Apache License 2.0
1 stars 1 forks source link

Feature/hostname in stackdriver logName #5

Closed brandonjbjelland closed 5 years ago

brandonjbjelland commented 5 years ago

What is this change?

  1. An enhancement to logging such that logName within StackDriver contains the hostname of the GCE instance.
  2. minor formatting fixes around the edges.

Why make this change?

This change helps engineers understand where logs are coming from.

brandonjbjelland commented 5 years ago

The implementation is opinionated but this gives some flexibility to the caller, allowing them to append the logName as they see fit. Resolves this issue: https://github.com/openx/ox-bqpipeline/issues/2

brandonjbjelland commented 5 years ago

Tests added.

Heh! I didn't see this PR until I submitted but looks like @shubhanan-ox is up to very similar here: https://github.com/openx/ox-bqpipeline/pull/4/files?file-filters%5B%5D=.py#diff-62db0910cd8a1b101462d1cb96406a21R56

jaketf commented 5 years ago

Closing this as it was looped into #4 by #6.