Add support for parameterized queries

openx / ox-bqpipeline

python framework for authoring BigQuery Pipelines for scheduling

Apache License 2.0

1 stars 1 forks source link

Add support for parameterized queries #9

Closed shubhanan-ox closed 5 years ago

shubhanan-ox commented 5 years ago

Still need to address a small few comments and add more unit tests around the type dict mapping. However, major refactoring stuff has been addressed and ready for a look. Also, had a couple of questions regarding the empty parameters handling. PTAL and let me know. Thanks!

shubhanan-ox commented 5 years ago

Thanks for the review! I am working on the pydoc. I am seeing some issues with the rendered markdown so, working through that.

shubhanan-ox commented 5 years ago

I've made the changes discussed today. PTAL. Thanks!

shubhanan-ox commented 5 years ago

Done.

shubhanan-ox commented 5 years ago

This addresses Issue #3