openxc / openxc-message-format

Specification for the OpenXC JSON message format
http://openxcplatform.com/
BSD 3-Clause "New" or "Revised" License
99 stars 35 forks source link

Update to protobuf 3.0 and re-generate. #30

Closed peplin closed 4 years ago

peplin commented 8 years ago

This also fixes a protobuf option that was pointing to a field that didn't exist (the capitalization didn't match), resolving the warning.

This needs to be tested on hardware - there may be changes in the 3.0 version of protobuf that effect functionality.

emarsman commented 8 years ago

I don't think nanopb supports protobuf 3.0 yet. Let me know if I'm missing something. https://github.com/nanopb/nanopb/issues/159 https://github.com/nanopb/nanopb/issues/182

I'm actually not sure that the recompile did much since we're still using nanopb 0.3.1 here. I like looking at python3 and proto3, but we may still be waiting on a few dependencies.

rhettschaefer commented 4 years ago

Upgrade to Protobuf3 was completed in the last release.

GenoJAFord commented 4 years ago

We have successfully upgraded to a more recent version of Protobuf 3 that is more compatible with all of our supported platforms. This Pull Request is now obsolete.