search

openxc / vi-firmware

OpenXC-compatible firmware for PIC32 and LPC1768
http://vi-firmware.openxcplatform.com
BSD 3-Clause "New" or "Revised" License
197 stars 105 forks source link

Fix: wrong dynamicField type used #380

Closed claneys closed 5 years ago

claneys commented 7 years ago

Change-Id: I6ac993babd2a0711c7f746e764fd5a150ffdd367 Signed-off-by: Romain Forlot romain.forlot@iot.bzh

emarsman commented 7 years ago

Thanks for the PR! Looks like a good change. Did you have an error or problem that lead you to find this?

claneys commented 7 years ago

Hi Eric,

You're welcome. No, in fact I never run the code but just read it :)

I'm part of AGL https://www.automotivelinux.org/ project and we attempt to achieve some very similar goals. So I take inspiration from you guys, thanks. You did great job here, and I hope there will be some others PR to do and mutual improvement.

Best regards.

On 02/13/2017 10:18 PM, Eric Marsman wrote:

Thanks for the PR! Looks like a good change. Did you have an error or problem that lead you to find this?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/openxc/vi-firmware/pull/380#issuecomment-279525463, or mute the thread https://github.com/notifications/unsubscribe-auth/AAf2gt7suBSEXl5zO0syXw7Ls7aHvL7eks5rcMi3gaJpZM4L9Xmo.

--

Romain Forlot - Embedded Engineer - IoT.bzh romain.forlot@iot.bzh - www.iot.bzh - +33257620298

claneys commented 7 years ago

Is there any problems with this pull requests ?

I see here from a while :)

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at ?% when pulling f1d517f40d0675a6c5c074284dc4a7b16c3dba0a on claneys:master into 70b8260f8b1488372b86b02a6746b5988eb78259 on openxc:master.