Resolve SonarQube Red Flag Issues

openxc / vi-firmware

OpenXC-compatible firmware for PIC32 and LPC1768

http://vi-firmware.openxcplatform.com

BSD 3-Clause "New" or "Revised" License

197 stars 105 forks source link

Resolve SonarQube Red Flag Issues #443

Closed PPRAKA30 closed 4 years ago

PPRAKA30 commented 4 years ago

Changes

Addressed most of the SonarQube red flag issues and code smells

Notes

The "c5" red flag and high complexity in the code coverage tool were two issues that were intentionally left in there. Once the project is migrated to enterprise SonarQube, these can be marked to ignore as changes to these may decrease readability of the code, thus may not be worth it.

coveralls commented 4 years ago

Coverage remained the same at ?% when pulling c8ad9182d73894da91782a5f46de4062d997056b on sonar-qube-flags into cb30c2dcaef073012b365db2047a6b73ac413a4b on next.