search

openxc / vi-firmware

OpenXC-compatible firmware for PIC32 and LPC1768
http://vi-firmware.openxcplatform.com
BSD 3-Clause "New" or "Revised" License
198 stars 106 forks source link

Get vin from diagnostic #462

Closed jstoke53 closed 3 years ago

jstoke53 commented 4 years ago

Add logic for the get_vin command to get VIN from a diagnostic request if it failed to get the VIN from CAN traffic. New logic in diagnostic.cpp to recognize if a diagnostic request is coming from the get_vin command.

Note: get_vin command diagnostic request is message_id:7e0, mode:9, pid:2. This may change in the future as we still have to look into why message_id:7df is not responding with the full VIN.

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 0.0% when pulling 1ca357360d128d5d696337c21a0c7159238cf012 on get-vin-from-diagnostic into 3d32f1af2c76e18bb6cb32e7fedc5e0cca4c7983 on next.

augusto2610 commented 3 years ago

Hi there, how can I build a custom firmware in this branch? I did git checkout get-vin-from-diagnostic then when I tried to build a firmware with the command "fab reference build" I got the following error:

diagnostics.cpp: In function 'void openxc::diagnostics::checkForVinCommand(CanMessage*)': diagnostics.cpp:528:47: error: 'openxc_ControlCommand_Type_GET_VIN' was not declared in this scope openxc::commands::sendCommandResponse(openxc_ControlCommand_Type_GET_VIN, 1, vin, strlen(vin)); ^ diagnostics.cpp: In function 'void openxc::diagnostics::sendGetVinError()': diagnostics.cpp:538:43: error: 'openxc_ControlCommand_Type_GET_VIN' was not declared in this scope openxc::commands::sendCommandResponse(openxc_ControlCommand_Type_GET_VIN, 0, errorGetVin, strlen(errorGetVin)); ^ platform/lpc17xx/lpc17xx.mk:107: recipe for target 'build/FORDBOARD/diagnostics.o' failed make: *** [build/FORDBOARD/diagnostics.o] Error 1

Could you please help me in order to build a firmware version?

Thanks in advance

jstoke53 commented 3 years ago

Hello @augusto2610, branch get-vin-from-diagnostic is still currently being worked on and tested. This branch alone will not be able to successfully build a working firmware. The work in this branch will hopefully be included in the next firmware release so I would keep an eye out for that release.

augusto2610 commented 3 years ago

Hello @augusto2610, branch get-vin-from-diagnostic is still currently being worked on and tested. This branch alone will not be able to successfully build a working firmware. The work in this branch will hopefully be included in the next firmware release so I would keep an eye out for that release.

Hi @jstoke53, thanks for the answer. I will be waiting for the next firmware release then.

Regards!