search

openxla / community

Stores documents and resources used by the OpenXLA developer community
Apache License 2.0
106 stars 23 forks source link

[RFC] Moving TSL into XLA #100

Open ddunl opened 11 months ago

ddunl commented 11 months ago

RFC about moving TSL into XLA. Please leave comments by Jan 12th!

i-chaochen commented 8 months ago

IIUC, tsl would move from xla/third_party/tsl to xla/tsl ?

ddunl commented 8 months ago

That's correct, that should be the only change inside the XLA repo

ManfeiBai commented 8 months ago

Hi, @ddunl, thanks for sharing this and here are some questions after reading the proposal:

  1. would this be a one/several PR change or a long list of PRs' change?

    • Currently, PyTorch/XLA update OpenXLA-pin monthly, and it seems PyTorch/XLA would include this change(@tsl to @xla/tsl) within one or several OpenXLA-pin updates;
    • To avoid crash&revert, could has a list of PyTorch/XLA PRs include per change to run CI tests before merge

  2. does TSL function interface be affected after the moving?

cc @miladm

ddunl commented 8 months ago

Hi Manfei,

  1. This will be several changes (probably around 40 or so)
  2. I should be able to do it in such a way that everything happens on a single pin update. PTXLA doesn't use TSL too much directly: https://github.com/search?q=repo%3Apytorch%2Fxla+%40tsl%2F%2F&type=code , and I was already planning on doing the tsl/platform code last as it is the most widely used.
  3. Only the moves of the targets in the above search will be affected, so I'll make sure that you are notified as those are submitted.
  4. None of the code itself should change, including symbol names (i.e. everything will still be in namespace tsl. This was a big problem moving to TSL, so I'm going to save the trouble this time and only move files and change target locations, not any of the code itself.