search

openxla / stablehlo

Backward compatible ML compute opset inspired by HLO/MHLO
Apache License 2.0
390 stars 105 forks source link

Small nit fix in gather/scatter batching index computation in evaluator #2351

Closed tomnatan30 closed 4 months ago

tomnatan30 commented 4 months ago

Use startIndicesIndex in Ops.cpp for computing gather/scatter batching index instead of batchIndex

GleasonK commented 4 months ago

cc @mlevesquedion any idea why that CI would be failing for a change like this?

GleasonK commented 4 months ago

CI failing at head. Merging this PR.

abhigunj commented 4 months ago

cc @mlevesquedion any idea why that CI would be failing for a change like this?

suspecting because pass documentation needs to be updated after https://github.com/openxla/stablehlo/pull/2253 changes.

I used ./build_tools/github_actions/ci_build_docs.sh to update the documentation, it fixed the issue for my TanOp RFC . I will submit the docs/generated/stablehlo_passes.md change separately as it is unrelated to my PR.