Take rank into account when checking if a DotGeneralOp is simple

openxla / stablehlo

Backward compatible ML compute opset inspired by HLO/MHLO

Apache License 2.0

390 stars 105 forks source link

Take rank into account when checking if a DotGeneralOp is simple #2370

Closed qingyunqu closed 4 months ago

qingyunqu commented 4 months ago

When the rank of either lhs or rhs is greater than 2, isSimpleDot may produce an incorrect result because of how getDefaultDotDimensionNumbers is implemented.