search

openxla / stablehlo

Backward compatible ML compute opset inspired by HLO/MHLO
Apache License 2.0
363 stars 101 forks source link

Don't apply `stablehlo-legalize-to-linalg` pass on ModuelOp. #2429

Closed shelkesagar29 closed 2 weeks ago

shelkesagar29 commented 2 weeks ago

Anchoring stablehlo-legalize-to-linalg on ModuleOp doesn't serve any specific purpose at this point. However, this makes it difficult to use this pass in any way for downstream stablehlo users. This change removes ModuleOp anchor from stablehlo-legalize-to-linalg pass.

google-cla[bot] commented 2 weeks ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

GleasonK commented 2 weeks ago

Hello! Thanks for the fix!

Could you sign the CLA as a next step? See the CI error for details, let me know if you hit any issues

shelkesagar29 commented 2 weeks ago

Hi @GleasonK I am not able to add reviewers, can you please review this? Thanks