openxla / xla

A machine learning compiler for GPUs, CPUs, and ML accelerators
Apache License 2.0
2.4k stars 361 forks source link

Fix //xla/service/gpu:ir_emitter_triton_mem_utils_test in OSS #14342

Closed sergey-kozub closed 1 day ago

sergey-kozub commented 3 days ago

Currently the test fails with:

xla/service/gpu/ir_emitter_triton_mem_utils_test.cc:48:10: fatal error: 'third_party/triton/include/triton/Dialect/Triton/IR/Dialect.h' file not found 48 | #include "third_party/triton/include/triton/Dialect/Triton/IR/Dialect.h"

Also, using cc_test instead of xla_cc_test results in linker errors

dimitar-asenov commented 3 days ago

I wonder what happened here, because that aspect of the test hasn't been changed recently. @sergey-kozub did this only recently start failing?

@ddunl did something change in how we translate paths between OSS and google3?

sergey-kozub commented 3 days ago

did this only recently start failing?

I believe it was always failing in OSS, we just don't run all the tests in OSS (for whatever reason)