search

openxla / xla

A machine learning compiler for GPUs, CPUs, and ML accelerators
Apache License 2.0
2.64k stars 418 forks source link

[ROCm] Fix build brake caused by missing dso_loader.h includes #17858

Closed mmakevic-amd closed 1 week ago

mmakevic-amd commented 1 week ago

The issue was introduced here -> https://github.com/openxla/xla/commit/b30b420510a89caa6ce9ae12c16add7e416e9034#diff-923ec2612240244a60ae28c17f798a7daeccbab84a8e9de9efd7ba96c311c763L115 Some of the ROCm files need dso_loader.h.

mmakevic-amd commented 1 week ago

Hi @klucke, with this change of yours https://github.com/openxla/xla/commit/6fd82343e4ce3729680931fd6cc240cbe0fbe237 this PR is not needed anymore, so I will close it.