search

openxla / xla

A machine learning compiler for GPUs, CPUs, and ML accelerators
Apache License 2.0
2.64k stars 418 forks source link

PR #17858: [ROCm] Fix build brake caused by missing dso_loader.h includes #17876

Open copybara-service[bot] opened 1 week ago

copybara-service[bot] commented 1 week ago

PR #17858: [ROCm] Fix build brake caused by missing dso_loader.h includes

Imported from GitHub PR https://github.com/openxla/xla/pull/17858

The issue was introduced here -> https://github.com/openxla/xla/commit/b30b420510a89caa6ce9ae12c16add7e416e9034#diff-923ec2612240244a60ae28c17f798a7daeccbab84a8e9de9efd7ba96c311c763L115 Some of the ROCm files need dso_loader.h. Copybara import of the project:

-- 38531050acc09a96cef2423694f9e106611aaac0 by Milica Makevic Milica.Makevic@amd.com:

Return dso_loader.h includes for ROCm

Merging this change closes #17858

FUTURE_COPYBARA_INTEGRATE_REVIEW=https://github.com/openxla/xla/pull/17858 from ROCm:ci_hotfix_241002 38531050acc09a96cef2423694f9e106611aaac0

klucke commented 1 week ago

I think this is now unnecessary -- I fixed it another way in https://github.com/openxla/xla/pull/17869