search

openxla / xla

A machine learning compiler for GPUs, CPUs, and ML accelerators
Apache License 2.0
2.64k stars 418 forks source link

`FunctionArgTypeConverterFn` under `BufferizationOptions` takes `FunctionOpInterface` instead of `func::FuncOp` #17935

Closed tzunghanjuang closed 1 week ago

tzunghanjuang commented 1 week ago

Description:

Hi! This PR is to synchronize with a recent LLVM/MLIR update (https://github.com/llvm/llvm-project/pull/110322). The update replaces func::FuncOp with FunctionOpInterface in many bufferization-related methods' signature. Now the signature of FunctionArgTypeConverterFn should contain FunctionOpInterface instead of func::FuncOp. Thank you very much!

 using FunctionArgTypeConverterFn = std::function<BaseMemRefType(
      TensorType, Attribute memorySpace, FunctionOpInterface,
      const BufferizationOptions &)>;

Related Changes in LLVM: https://github.com/llvm/llvm-project/pull/110322/files#diff-0a1a3b3003580d05064692dc58271a17ca2d65ea69a11da1cb92f4102fbb1a20L262-L266

google-cla[bot] commented 1 week ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

ezhulenev commented 1 week ago

Thanks! This API was already updated by another internal change.