search

openxla / xla

A machine learning compiler for GPUs, CPUs, and ML accelerators
Apache License 2.0
2.69k stars 434 forks source link

[xla:gpu] Move thunks under xla/service/gpu/runtime3 #5758

Open ezhulenev opened 1 year ago

ezhulenev commented 1 year ago

Currently XLA:GPU thunks are in the same folder with all of compiler passes and random utilities in one giant folder with hundreds of files (https://github.com/openxla/xla/tree/main/xla/service/gpu). Let's move all thunk-related targets to: https://github.com/openxla/xla/tree/main/xla/service/gpu/runtime3

This is a temporary location, once clean up and consolidation is completed we'll find Thunks a new home in XLA directory structure.

Thunk: https://github.com/openxla/xla/blob/main/xla/service/gpu/thunk.h

sgerrard commented 1 year ago

@ezhulenev There are set of Thunks built in the gpu_executable library Some thunks are built separately. Should we move the thunks out of this library, leave them where they are or move the gpu_executable to the new runtime location?

ezhulenev commented 1 year ago

All thunks should have their own build targets (faster parallel builds), I think some of them built as a part for gpu_executable to avoid circular dependencies, but I suspect some of them are there accidentally. Anyway we'll need to find a way to break circular dependency if it exists.

penpornk commented 8 months ago

Closing this issue since thunks had been moved to xla/service/gpu/runtime3 and has now become the only runtime for XLA:GPU (xla/service/gpu/runtime)

penpornk commented 8 months ago

Oops I just saw that the issue is still being used. Sorry, reopening now.