openxrlab / xrmocap

OpenXRLab Multi-view Motion Capture Toolbox and Benchmark
https://xrmocap.readthedocs.io/
Other
348 stars 42 forks source link

[Refactor] Replace the components with those defined in XRPrimer #115

Closed LazyBusyYang closed 1 year ago

LazyBusyYang commented 1 year ago
  1. Import data structures Keypoints Limbs and their transfom functions from XRPrimer. Remove the definition in XRMoCap and leave a warning log.
  2. Do not install or test mmtrack by default, because its requirements is too strict.
  3. Use visualization in XRPrimer for MviewMpersonDataVisualization.
  4. Fix the wrong frame number error in PanopticDataCovnerter
  5. Remove xrmocap/io/h5py_helper.py which is not used anywhere.
  6. Fix outdated numpy import (bool, int, float), but numpy<1.24 is still required by package smplx.
  7. Update dockerfile and docker build script.
codecov-commenter commented 1 year ago

Codecov Report

Merging #115 (9b14024) into main (a9207b0) will decrease coverage by 1.27%. The diff coverage is 77.96%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
- Coverage   62.46%   61.19%   -1.27%     
==========================================
  Files         181      178       -3     
  Lines       11444    11097     -347     
==========================================
- Hits         7148     6791     -357     
- Misses       4296     4306      +10     
Flag Coverage Δ
unittests 61.19% <77.96%> (-1.27%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
xrmocap/core/estimation/mperson_smpl_estimator.py 0.00% <0.00%> (ø)
...core/estimation/mview_mperson_end2end_estimator.py 0.00% <0.00%> (ø)
...core/estimation/mview_mperson_topdown_estimator.py 0.00% <0.00%> (ø)
...ap/core/estimation/mview_sperson_smpl_estimator.py 0.00% <0.00%> (ø)
xrmocap/io/__init__.py 100.00% <ø> (ø)
...ransform/keypoints3d/optim/fourdag_optimization.py 86.66% <ø> (ø)
xrmocap/visualization/render/mpr_renderer.py 24.52% <ø> (ø)
xrmocap/visualization/visualize_smpl.py 13.79% <ø> (ø)
xrmocap/data_structure/limbs.py 66.66% <42.85%> (-31.42%) :arrow_down:
xrmocap/data_structure/keypoints.py 62.50% <50.00%> (-29.34%) :arrow_down:
... and 45 more

... and 1 file with indirect coverage changes