openxrlab / xrsfm

OpenXRLab Structure-from-Motion Toolbox and Benchmark
Apache License 2.0
185 stars 22 forks source link

Error: wrong results on colmap demo datasets person-hall #36

Closed cv-lab-x closed 3 months ago

cv-lab-x commented 4 months ago

thanks for your great work, xrsfm is much faster than colmap, but the results seem to be poor, i use the default params in the readme, how to improve the results? the link of the demo datasets: https://demuc.de/colmap/datasets/ Person-hall

xrsfm results:

image

the gt: image

Looking forward to your reply, thanks! @oneLOH

oneLOH commented 4 months ago

Thank you for reporting this issue. After ensuring the camera parameters are set correctly, I have observed a noticeable improvement in the reconstruction process. Nevertheless, there are still some problem that need to be addressed. I anticipate that this endeavor will take approximately one to two weeks to complete.

xrsfm results (with given camera parameters): WXWorkCapture_17101363838763

oneLOH commented 3 months ago

The main cause of this issue is the incorrect image rotation when using cv::imread without IMREAD_IGNORE_ORIENTATION. The commit (https://github.com/openxrlab/xrsfm/commit/3439677f798e73f3ac5aeb00e730fe9aed8eb194) has already fixed this issue.

Please note that when calling the reconstruction command, the camera intrinsic parameters need to be specified. ./bin/run_reconstruction /data/person-hall/ /data/person-hall/sparse/cameras.txt /cephfs/person-hall/results/

xrsfm results: WXWorkCapture_17103840588800

cv-lab-x commented 3 months ago

The main cause of this issue is the incorrect image rotation when using cv::imread without IMREAD_IGNORE_ORIENTATION. The commit (3439677) has already fixed this issue.

Please note that when calling the reconstruction command, the camera intrinsic parameters need to be specified. ./bin/run_reconstruction /data/person-hall/ /data/person-hall/sparse/cameras.txt /cephfs/person-hall/results/

xrsfm results: WXWorkCapture_17103840588800

great, huge improvement, I'll try, thanks for your work./