search

openyou / emokit

Open source driver for accessing raw data from the Emotiv EPOC EEG headset
http://www.openyou.org
Other
523 stars 236 forks source link

Update packet sensor value to be signed, corrected value logic in render.py #125

Closed ghost closed 9 years ago

ghost commented 10 years ago

Corrected sensor output and rendering.

nh2 commented 9 years ago

@bschumacher @fractalcat What's the idea behind that, do we know that the value is suposed to be signed (for some processing program), or do we just want it to appear so?

ghost commented 9 years ago

It is an analog wave value. Does it break your processing application or was it just a question?

Thanks, Bill Schumacher

On Mar 3, 2015, at 1:07 PM, Niklas Hambüchen notifications@github.com wrote:

@bschumacher @fractalcat What's the idea behind that, do we know that the value is suposed to be signed (for some processing program), or do we just want it to appear so?

— Reply to this email directly or view it on GitHub.

olorin commented 9 years ago

The raw value is unsigned (1 LSB to 0.51 microvolts); as @bschumacher says, the observation is of a signed quantity with (digital) range -2^13 to 2^13. At least, I assume it is - it's not mentioned in the device docs, but I don't see how any other interpretation would make sense. Do you disagree with the interpretation of the data, or with the fact of interpreting the data rather than using the raw values?

nh2 commented 9 years ago

No, it was just a question - given that the old unsigned behaviour had been there for so long.

Thanks for the explanation! Feel free to close.

olorin commented 9 years ago

Yeah, I'm not sure what the logic behind the original behaviour was; I never used the Python module myself so I only noticed it when @bschumacher pointed it out.

Already closed. :)