Closed rambohe-ch closed 7 months ago
/assign @wangzihao05
@wangzihao05 Do you have any progress about this issue?
I have understood this issue.The problem is that struct that is supposed to be string is causing the log exception. I have modified part of the code as required.And I will finish and commit later this week.
I have understood this issue.The problem is that struct that is supposed to be string is causing the log exception. I have modified part of the code as required.And I will finish and commit later this week.
@wangzihao05 Thanks for your kindly response.
yes, var key
is a pointer of a struct, so you need to replace key
by key.Key()
only.
Since the pr has been merged, close.
/close
What would you like to be added: There are some tricky logs in yurthub component as following:
The reason is that var
key
is a struct not a string, so%s
inklog.Infof
print the above tricky logs.so the following code should be modified:
current: https://github.com/openyurtio/openyurt/blob/9fb701eb8b5d50c97674f441fede8273149fec73/pkg/yurthub/cachemanager/cache_manager.go#L650
improved:
by the way, the following lines have the same kind of problems.
https://github.com/openyurtio/openyurt/blob/9fb701eb8b5d50c97674f441fede8273149fec73/pkg/yurthub/cachemanager/cache_manager.go#L630
https://github.com/openyurtio/openyurt/blob/9fb701eb8b5d50c97674f441fede8273149fec73/pkg/yurthub/cachemanager/cache_manager.go#L644
others /kind feature