openyurtio / openyurt

OpenYurt - Extending your native Kubernetes to edge(project under CNCF)
https://openyurt.io
Apache License 2.0
1.71k stars 402 forks source link

Feature: add yurtappset v1beta1 #1939

Closed luc99hen closed 8 months ago

luc99hen commented 9 months ago

What type of PR is this?

/kind feature

What this PR does / why we need it:

Following the proposal https://github.com/openyurtio/openyurt/pull/1890 https://github.com/openyurtio/openyurt/pull/1931

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@rambohe-ch

Does this PR introduce a user-facing change?

other Note

codecov[bot] commented 9 months ago

Codecov Report

Attention: 282 lines in your changes are missing coverage. Please review.

Comparison is base (da03883) 52.04% compared to head (c3bfe1a) 52.39%. Report is 2 commits behind head on master.

Files Patch % Lines
...ger/controller/yurtappset/yurtappset_controller.go 49.63% 118 Missing and 21 partials :warning:
...r/yurtappset/workloadmanager/deployment_manager.go 54.46% 37 Missing and 14 partials :warning:
...ebhook/yurtappset/v1beta1/yurtappset_validation.go 27.50% 21 Missing and 8 partials :warning:
pkg/yurtmanager/controller/yurtappset/revision.go 74.74% 20 Missing and 5 partials :warning:
...ager/controller/yurtappset/workloadmanager/util.go 78.31% 14 Missing and 4 partials :warning:
...er/controller/yurtappset/workloadmanager/tweaks.go 87.32% 6 Missing and 3 partials :warning:
pkg/yurtmanager/controller/yurtappset/utils.go 83.87% 3 Missing and 2 partials :warning:
...tmanager/controller/util/refmanager/ref_manager.go 0.00% 4 Missing :warning:
...r/webhook/yurtappset/v1beta1/yurtappset_handler.go 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1939 +/- ## ========================================== + Coverage 52.04% 52.39% +0.34% ========================================== Files 174 173 -1 Lines 21213 21007 -206 ========================================== - Hits 11040 11006 -34 + Misses 9199 9051 -148 + Partials 974 950 -24 ``` | [Flag](https://app.codecov.io/gh/openyurtio/openyurt/pull/1939/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openyurtio) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/openyurtio/openyurt/pull/1939/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openyurtio) | `52.39% <61.36%> (+0.34%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openyurtio#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

luc99hen commented 9 months ago

/rerun

rambohe-ch commented 8 months ago

/rerun

luc99hen commented 8 months ago

e2e fail due to the compatibility issues implemented in convert logic, currently known issues are:

  1. v1alpha1 status replicas, readyReplicas can not obtained from v1beta1, use estimate workload*defaultReplica
  2. v1alpha1 status currenetRevision conversion logic missing
  3. v1alpha1 spec selector can not obtained from v1beta1 directly, use deployment/statefulset selector
sonarcloud[bot] commented 8 months ago

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

11 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

rambohe-ch commented 8 months ago

/lgtm