openyurtio / openyurt

OpenYurt - Extending your native Kubernetes to edge(project under CNCF)
https://openyurt.io
Apache License 2.0
1.69k stars 398 forks source link

fix:readme slack url #1945

Closed karthik507 closed 7 months ago

karthik507 commented 7 months ago

Readme file update with new slack url , kindly update the new url.

YTGhost commented 7 months ago

@karthik507 The revised link is not the same as the one @rambohe-ch provided before?

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3c3b3cb) 51.98% compared to head (2322cd0) 52.03%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1945 +/- ## ========================================== + Coverage 51.98% 52.03% +0.04% ========================================== Files 174 174 Lines 21213 21213 ========================================== + Hits 11028 11038 +10 + Misses 9210 9201 -9 + Partials 975 974 -1 ``` | [Flag](https://app.codecov.io/gh/openyurtio/openyurt/pull/1945/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openyurtio) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/openyurtio/openyurt/pull/1945/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openyurtio) | `52.03% <ø> (+0.04%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openyurtio#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

karthik507 commented 7 months ago

@karthik507 The revised link is not the same as the one @rambohe-ch provided before?

@YTGhost the link which you gave was working url :https://join.slack.com/t/openyurt/shared_invite/zt-2bptiyzuv-oDDlfdLwS0AuxSyD4cq4eA and @rambohe-ch url was different and that was also working ,i updated the url which you gave.

YTGhost commented 7 months ago

@karthik507 The revised link is not the same as the one @rambohe-ch provided before?

@YTGhost the link which you gave was working url :https://join.slack.com/t/openyurt/shared_invite/zt-2bptiyzuv-oDDlfdLwS0AuxSyD4cq4eA and @rambohe-ch url was different and that was also working ,i updated the url which you gave.

The URL I provided appears to expire, but @rambohe-ch gave does not. Please change it to the one he provided.

karthik507 commented 7 months ago

@karthik507 The revised link is not the same as the one @rambohe-ch provided before?

@YTGhost the link which you gave was working url :https://join.slack.com/t/openyurt/shared_invite/zt-2bptiyzuv-oDDlfdLwS0AuxSyD4cq4eA and @rambohe-ch url was different and that was also working ,i updated the url which you gave.

The URL I provided appears to expire, but @rambohe-ch gave does not. Please change it to the one he provided.

@YTGhost okay

sonarcloud[bot] commented 7 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

rambohe-ch commented 7 months ago

/lgtm

rambohe-ch commented 7 months ago

Fixes #1944