Closed huangchenzhao closed 5 months ago
Attention: Patch coverage is 68.88889%
with 14 lines
in your changes are missing coverage. Please review.
Project coverage is 52.37%. Comparing base (
34b14cc
) to head (44ad71e
). Report is 1 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
...kg/yurtmanager/webhook/pod/v1alpha1/pod_handler.go | 0.00% | 14 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
/rerun
@huangchenzhao filter hostnetworkpropagation also should be removed.
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
@huangchenzhao filter hostnetworkpropagation also should be removed.
removed
/lgtm
What type of PR is this?
What this PR does / why we need it:
A mutating webhook is introduced in yurt-manager component for adding NodeAffinity to pods with
annotation["apps.openyurt.io/exclude-host-network-pool"] = true
. The NodeAffinity indicates that the pods don't want to be scheduled to nodes in hostNetwork mode NodePool.Users should add
annotation ["apps.openyurt.io/exclude-host-network-pool"] = true
manually to pods if they don't want to run pods on edge nodes in hostNetwork mode nodepool.Which issue(s) this PR fixes:
Fixes #1935