openyurtio / openyurt

OpenYurt - Extending your native Kubernetes to edge(project under CNCF)
https://openyurt.io
Apache License 2.0
1.69k stars 398 forks source link

fix: ensure local proxy can handle requests with the same path but with different selector #1964

Closed windnod closed 2 months ago

windnod commented 5 months ago

What type of PR is this?

/kind bug

What this PR does / why we need it:

skip the check for the same path list requests, when the localproxy use the canCacheFor() method

Which issue(s) this PR fixes:

Fixes #1963

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 52.41%. Comparing base (c8778fc) to head (6938de3). Report is 55 commits behind head on master.

Files Patch % Lines
pkg/yurthub/proxy/remote/loadbalancer.go 0.00% 2 Missing :warning:
pkg/yurthub/proxy/local/local.go 0.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1964 +/- ## ======================================= Coverage 52.41% 52.41% ======================================= Files 173 173 Lines 21015 21015 ======================================= Hits 11014 11014 Misses 9051 9051 Partials 950 950 ``` | [Flag](https://app.codecov.io/gh/openyurtio/openyurt/pull/1964/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openyurtio) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/openyurtio/openyurt/pull/1964/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openyurtio) | `52.41% <40.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openyurtio#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rambohe-ch commented 5 months ago

@windnod Thanks for posting pull request. I have commented the issue #1963 , and we need to have more discussion about this case before we merge this pull request. sorry to response you lately.

stale[bot] commented 2 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.