Closed vie-serendipity closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 52.41%. Comparing base (
34b14cc
) to head (fd4ba7e
). Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
@vie-serendipity Thank you for posting the pull request to improve YurtAppSet workload. I agree with you that deployment render webhook should effect v1alpha1.YurtAppSet only.
/lgtm
…pset v1alpha1
What type of PR is this?
/kind bug
What this PR does / why we need it:
Yurtappset is updated to v1beta1. Now deployment render will mutate all workloads created by yurtappset. Actually, yurtappoverrider should only manage workloads created by yurtappset v1alpha1. Otherwise, it will cause unexpected errors. So we should add some restrictions to deployment webhook of yurtappoverrider.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note