Closed huangchenzhao closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 52.90%. Comparing base (
273e8df
) to head (e0a7df7
). Report is 6 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@vie-serendipity PTAL
/rerun
Issues
1 New issue
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
/rerun
/lgtm @rambohe-ch
/lgtm
What type of PR is this?
What this PR does / why we need it:
such as https://github.com/openyurtio/openyurt/blob/34b14ccadfe26b8956144d21ec62a79a3aef1760/pkg/yurtmanager/controller/yurtappset/revision.go#L96
https://github.com/openyurtio/openyurt/blob/34b14ccadfe26b8956144d21ec62a79a3aef1760/pkg/yurtmanager/controller/yurtappset/revision.go#L103
https://github.com/openyurtio/openyurt/blob/34b14ccadfe26b8956144d21ec62a79a3aef1760/pkg/yurtmanager/controller/yurtappset/revision.go#L193
they all call functions in
k8s.io/kubernetes/pkg/controller/history
, for avoiding this, just simply copy related functions codes intopkg/util/kebernetes
, then we can call these functions in our directory.Which issue(s) this PR fixes:
Fixes #1967