Closed rambohe-ch closed 5 months ago
Issues
1 New issue
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code
Attention: Patch coverage is 77.27273%
with 5 lines
in your changes are missing coverage. Please review.
Project coverage is 53.04%. Comparing base (
acec197
) to head (41abd56
).
Files | Patch % | Lines |
---|---|---|
pkg/yurthub/filter/responsefilter/filter.go | 76.19% | 3 Missing and 2 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Move list object handling in every ObjectFilter(like masterservice, servicetopology, etc.) into
ResponseFilter
, so each ObjectFilter only need to handle single object.Which issue(s) this PR fixes:
Fixes #1990
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note