openyurtio / openyurt

OpenYurt - Extending your native Kubernetes to edge(project under CNCF)
https://openyurt.io
Apache License 2.0
1.69k stars 398 forks source link

move list object handling from ObjectFilter into ResponseFilter #1991

Closed rambohe-ch closed 5 months ago

rambohe-ch commented 5 months ago

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line: /kind bug /kind documentation /kind enhancement /kind good-first-issue /kind feature /kind question /kind design /sig ai /sig iot /sig network /sig storage

/kind feature

What this PR does / why we need it:

Move list object handling in every ObjectFilter(like masterservice, servicetopology, etc.) into ResponseFilter, so each ObjectFilter only need to handle single object.

Which issue(s) this PR fixes:

Fixes #1990

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 77.27273% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 53.04%. Comparing base (acec197) to head (41abd56).

Files Patch % Lines
pkg/yurthub/filter/responsefilter/filter.go 76.19% 3 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1991 +/- ## ========================================== + Coverage 52.90% 53.04% +0.13% ========================================== Files 176 176 Lines 20959 20929 -30 ========================================== + Hits 11089 11101 +12 + Misses 8918 8881 -37 + Partials 952 947 -5 ``` | [Flag](https://app.codecov.io/gh/openyurtio/openyurt/pull/1991/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openyurtio) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/openyurtio/openyurt/pull/1991/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openyurtio) | `53.04% <77.27%> (+0.13%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openyurtio#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.