search

openyurtio / openyurt

OpenYurt - Extending your native Kubernetes to edge(project under CNCF)
https://openyurt.io
Apache License 2.0
1.69k stars 398 forks source link

[BUG] yurt-iot-dock v1.4.1 doesn't match the edgex v3.1.0 #1992

Closed 24sama closed 1 month ago

24sama commented 5 months ago

What happened: When I deploy yurt-iot-dock v1.4.1, I fount it doesn't match the edgex v3.1.0.

image

And I see the code logic of the release-v1.4 branch and v1.4.1 tag, which all don't contain the "napa". https://github.com/openyurtio/openyurt/blob/cb2055bc5ba04b202900eaeeda3437eea1192626/pkg/yurtiotdock/clients/edgex-foundry/edgexobject.go#L44-L69

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

others

/kind bug

rambohe-ch commented 5 months ago

@zyjhtangtang @LavenderQAQ PTAL

LavenderQAQ commented 5 months ago

@24sama Thank you for raising this issue. In fact, this should already be supported. We just need to add the napa case. Could you submit a pr to help fix this?

24sama commented 5 months ago

@LavenderQAQ Got it, and I found this PR: https://github.com/openyurtio/openyurt/pull/1850 Maybe we can cherry-pick this PR into release-v1.4

Another question, if I build the yurt-iot-dock from release-v1.4 source code, Is it will miss some feature or bugfix PR which is compared to official v1.4.1 version?

LavenderQAQ commented 5 months ago

@24sama When 1.4 was released, there was no napa release yet. This is a more recent version that we support, and we can fix it directly on master.

24sama commented 5 months ago

Thanks @LavenderQAQ , so it means there is only a master branch that supports napa release. And how soon is the official plan to release a new version with napa support? Just like this, we can checkout a new release branch that includes all master PR, and can build it from the release branch.

rambohe-ch commented 4 months ago

Thanks @LavenderQAQ , so it means there is only a master branch that supports napa release. And how soon is the official plan to release a new version with napa support? Just like this, we can checkout a new release branch that includes all master PR, and can build it from the release branch.

@24sama we plan to release OpenYurt v1.5 in the middle of April, please stay in tune.

stale[bot] commented 1 month ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.